API Updates #1328
API Updates #1328
Conversation
|
Something is up with our codegen and removed Charge#ShippingDetails. Looking... |
There was a problem hiding this comment.
left some comments early but will defer to @richardm-stripe for final review
| Phone string `json:"phone"` | ||
| TrackingNumber string `json:"tracking_number"` | ||
| } | ||
|
|
There was a problem hiding this comment.
Whis is this disappearing?
There was a problem hiding this comment.
Re-added - it should've been manually specified in address.go.
| issuingcard "github.com/stripe/stripe-go/v72/issuing/card" | ||
| "github.com/stripe/stripe-go/v72/issuing/cardholder" | ||
| issuingcardholder "github.com/stripe/stripe-go/v72/issuing/cardholder" |
There was a problem hiding this comment.
are those changes breaking changes?
There was a problem hiding this comment.
This was actually merged in #1323 .
| type ReviewReason string | ||
|
|
||
| // Deprecated: we preserve this name for backwards-compatibility, prefer `ReviewReason`. | ||
| type ReviewReasonType = ReviewReason |
There was a problem hiding this comment.
is this a breaking change or are type aliasing safe, same for the one below
There was a problem hiding this comment.
Type aliasing here should be safe.
| @@ -86,11 +97,11 @@ type Review struct { | |||
| Open bool `json:"open"` | |||
| OpenedReason ReviewOpenedReason `json:"opened_reason"` | |||
| PaymentIntent *PaymentIntent `json:"payment_intent"` | |||
| Reason ReviewReasonType `json:"reason"` | |||
| Reason ReviewReason `json:"reason"` | |||
There was a problem hiding this comment.
Type aliasing here should be safe.
I've ran into this with Richard at some point and his suggestion was to move |
dcr-stripe
force-pushed
the
dcr-latest-codegen
branch
from
3b2420e to
d0d448e
Compare
| type ChargePaymentMethodDetailsSepaCreditTransfer struct { | ||
| BankName string `json:"bank_name"` | ||
| Bic string `json:"bic"` | ||
| Iban string `json:"iban"` | ||
| } |
There was a problem hiding this comment.
| type ChargePaymentMethodDetailsSepaCreditTransfer struct { | |
| BankName string `json:"bank_name"` | |
| Bic string `json:"bic"` | |
| Iban string `json:"iban"` | |
| } | |
| type ChargePaymentMethodDetailsSepaCreditTransfer struct { | |
| BankName string `json:"bank_name"` | |
| BIC string `json:"bic"` | |
| IBAN string `json:"iban"` | |
| } |
There was a problem hiding this comment.
Actually nevermind, we don't capitalize these acronyms anywhere and should be consistent with elsewhere.
There was a problem hiding this comment.
Actually nevermind, we don't capitalize these acronyms anywhere and should be consistent with elsewhere.
Codegen for openapi 10ebdb9.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
au_arnInteracPresentonChargePaymentMethodDetailsSepaCreditTransferonChargePaymentMethodDetailsShippingDetailsintoaddress.goObjectandOrdertoChargeReviewReasonTypeenum toReviewReasonbut added a type alias to preserve backwards compatibility